Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(deps): switch to commit-and-tag-version #2882

Merged
merged 3 commits into from
May 11, 2024
Merged

infra(deps): switch to commit-and-tag-version #2882

merged 3 commits into from
May 11, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 6, 2024

Replaces the standard-version dependency with the maintained fork commit-and-tag-version.

I did some tests locally and release seems to behave the exact same as standard-version, but you might want to try it out yourself.

I also explicitly disabled the tag generation, as we generate the tags via GH releases anyway.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency labels May 6, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 6, 2024
@ST-DDT ST-DDT requested review from a team May 6, 2024 08:59
@ST-DDT ST-DDT self-assigned this May 6, 2024
@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 79ea746
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663f755d187acd000878ce01
😎 Deploy Preview https://deploy-preview-2882.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT changed the title chore(deps): switch to commit-and-tag-version infra(deps): switch to commit-and-tag-version May 6, 2024
@ST-DDT ST-DDT added c: infra Changes to our infrastructure or project setup and removed c: chore PR that doesn't affect the runtime behavior labels May 6, 2024
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (042c871) to head (79ea746).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2882    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2977     2977            
  Lines      215466   215466            
  Branches      950      601   -349     
========================================
+ Hits       215387   215395     +8     
+ Misses         79       71     -8

see 1 file with indirect coverage changes

Shinigami92
Shinigami92 previously approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ST-DDT ST-DDT mentioned this pull request May 6, 2024
Merged
6 tasks
@ST-DDT ST-DDT requested a review from a team May 6, 2024 09:46
@xDivisionByZerox
Copy link
Member

We already had a config file for standard version: https://github.com/faker-js/faker/blob/043f68b0691f1cc1c11f2257b9c9e2cfa5047c72/.versionrc.json
If I understand correctly, we can keep using it. The new config should propably go into the config file instead of the package.json.

@ST-DDT
Copy link
Member Author

ST-DDT commented May 6, 2024

We already had a config file for standard version: 043f68b/.versionrc.json If I understand correctly, we can keep using it. The new config should propably go into the config file instead of the package.json.

It doesn't show up in the config spec, but seems to work anyway.
https://github.com/conventional-changelog/conventional-changelog-config-spec/blob/master/versions/2.2.0/README.md

@ST-DDT ST-DDT requested a review from Shinigami92 May 6, 2024 17:39
@ST-DDT ST-DDT mentioned this pull request May 6, 2024
Open
@xDivisionByZerox
Copy link
Member

It doesn't show up in the config spec, but seems to work anyway.

It's not obvious but as they state in their README:

Any of the command line parameters accepted by commit-and-tag-version can instead be provided via configuration.

In combination with the point aboth:

You can configure commit-and-tag-version either by:

  1. Placing a commit-and-tag-version stanza in your package.json
  2. Creating a .versionrc, .versionrc.json or .versionrc.js.

@xDivisionByZerox xDivisionByZerox requested a review from a team May 8, 2024 10:00
@ST-DDT ST-DDT merged commit fe76110 into next May 11, 2024
20 checks passed
@ST-DDT ST-DDT deleted the chore/deps/commit-and-tag-version branch May 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @xDivisionByZerox @Shinigami92 @import-brain